Add reference element reads - #153
Merged
Merged
Conversation
This was referenced Aug 29, 2026
ero-qt
force-pushed
the
reference-collections
branch
14 times, most recently
from
September 17, 2026 20:52
e0c22dd to
a6eff49
Compare
ero-qt
force-pushed
the
reference-collections
branch
from
September 18, 2026 02:49
a6eff49 to
a263be6
Compare
CryZe
approved these changes
Sep 18, 2026
CryZe
left a comment
CryZe
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the public API and implementation, ran the full local test suite, and verified read_reference_list, read_reference_array, and read_string_object against a live Lunistice IL2CPP process. All three passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #149.
Adds
read_reference_arrayandread_reference_list, which hand back the elements' object addresses, andread_string_object, which reads a string at one of those addresses.read_stringis a dereference followed byread_string_object.string[]andList<string>become readable.Reference elements are pointers at the target's width, so a width claim through
read_arraycompiles at either width and silently answers garbage at the wrong one. These readers own the width. Null elements come back as null addresses at their positions, and only a null collection reference refuses.Custom-class elements work the same way. The object address plus
get_field_offsetreads fields directly.cargo test --all-featuresruns the suite. The new tests cover reference arrays and lists on both runtimes, lengths past the buffer, nulls kept in place, and string objects at their addresses.